[asterisk-dev] [Code Review] 2597: Implement POST to channels, to originate a call.

[Jason Parker]

> On June 6, 2013, 1:38 p.m., opticron wrote:
> > /trunk/res/stasis_http/resource_channels.c, line 357
> > <https://reviewboard.asterisk.org/r/2597/diff/1/?file=39179#file39179line357>
> >
> >     A failure to originate should be reported and a success should report the created channel. The 12th parameter will be filled in with the locked channel created if you provide it with a struct ast_channel**.

If we pass in a channel, the function blocks until it gets answered.  That is bad.  I can respond with failure if the dial thread fails to start though.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2597/#review8821
-----------------------------------------------------------


On June 5, 2013, 7:10 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2597/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 7:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21617
>     https://issues.asterisk.org/jira/browse/ASTERISK-21617
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This doesn't support CallerID or codec selection, like the manager action.  Should it?
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stasis_http_channels.c 390539 
>   /trunk/res/stasis_http/resource_channels.h 390539 
>   /trunk/res/stasis_http/resource_channels.c 390539 
>   /trunk/res/stasis_json/resource_channels.h 390539 
>   /trunk/rest-api/api-docs/channels.json 390539 
> 
> Diff: https://reviewboard.asterisk.org/r/2597/diff/
> 
> 
> Testing
> -------
> 
> Calls get made to the location you specify.  The call gets put into the Stasis application when it gets answered.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/5879a447/attachment.htm>