[asterisk-dev] [Code Review] 2597: Implement POST to channels, to originate a call.

[Mark Michelson]

> On June 6, 2013, 1:38 p.m., opticron wrote:
> > /trunk/res/stasis_http/resource_channels.c, lines 336-344
> > <https://reviewboard.asterisk.org/r/2597/diff/1/?file=39179#file39179line336>
> >
> >     The documentation mentions nothing about this silently becoming a local channel dial when the tech is omitted from the endpoint.

In addition, unless "stuff" here ends up being in the form exten at context, the attempt to dial the local channel will fail. IMO, it's best to error out if the endpoint name is malformed.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2597/#review8821
-----------------------------------------------------------


On June 5, 2013, 7:10 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2597/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 7:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21617
>     https://issues.asterisk.org/jira/browse/ASTERISK-21617
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This doesn't support CallerID or codec selection, like the manager action.  Should it?
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stasis_http_channels.c 390539 
>   /trunk/res/stasis_http/resource_channels.h 390539 
>   /trunk/res/stasis_http/resource_channels.c 390539 
>   /trunk/res/stasis_json/resource_channels.h 390539 
>   /trunk/rest-api/api-docs/channels.json 390539 
> 
> Diff: https://reviewboard.asterisk.org/r/2597/diff/
> 
> 
> Testing
> -------
> 
> Calls get made to the location you specify.  The call gets put into the Stasis application when it gets answered.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/0a378fa6/attachment-0001.htm>