[asterisk-dev] [Code Review] 2572: Stasis-HTTP: Flesh out bridging capabilities

[opticron]

> On June 3, 2013, 4 p.m., David Lee wrote:
> > trunk/res/res_stasis.c, line 772
> > <https://reviewboard.asterisk.org/r/2572/diff/1/?file=38772#file38772line772>
> >
> >     What's with the copy?

The incoming value is const and the callback takes a non-const.


> On June 3, 2013, 4 p.m., David Lee wrote:
> > trunk/res/stasis_http/resource_bridges.c, lines 152-157
> > <https://reviewboard.asterisk.org/r/2572/diff/1/?file=38780#file38780line152>
> >
> >     There's also a 409 condition where the given channel isn't in the given bridge.

Added a BUGBUG since getting this information will be trivial once the bridge uniqueid is added to the channel snapshot, but is currently far from it.


> On June 3, 2013, 4 p.m., David Lee wrote:
> > trunk/include/asterisk/stasis_app.h, line 197
> > <https://reviewboard.asterisk.org/r/2572/diff/1/?file=38769#file38769line197>
> >
> >     This should really take an ast_bridge_capability instead of a string. The string-to-flag conversion should happen at a higher layer (although a parsing function makes sense in bridging.h, so it's consistent.)

This has been changed enough that there is no longer a direct string->flag relationship.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2572/#review8773
-----------------------------------------------------------


On May 29, 2013, 2:09 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2572/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 2:09 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Bugs: ASTERISK-21711
>     https://issues.asterisk.org/jira/browse/ASTERISK-21711
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds support for Stasis applications to receive bridge-related messages when the application shows interest in a given bridge.
> 
> To supplement this work and test it, this also adds support for the following bridge-related Stasis-HTTP functionality:
> * GET stasis/bridges
> * GET stasis/bridges/{bridgeId}
> * POST stasis/bridges
> * DELETE stasis/bridges/{bridgeId}
> * POST stasis/bridges/{bridgeId}/addChannel
> * POST stasis/bridges/{bridgeId}/removeChannel
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/stasis_app.h 390037 
>   trunk/include/asterisk/stasis_bridging.h 390037 
>   trunk/main/stasis_bridging.c 390037 
>   trunk/res/res_stasis.c 390037 
>   trunk/res/res_stasis_bridge_add.c PRE-CREATION 
>   trunk/res/res_stasis_bridge_add.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_events.c 390037 
>   trunk/res/res_stasis_json_events.exports.in 390037 
>   trunk/res/stasis/app.h 390037 
>   trunk/res/stasis/app.c 390037 
>   trunk/res/stasis/control.c 390037 
>   trunk/res/stasis_http/resource_bridges.c 390037 
>   trunk/res/stasis_json/resource_events.h 390037 
>   trunk/rest-api/api-docs/bridges.json 390037 
>   trunk/rest-api/api-docs/events.json 390037 
> 
> Diff: https://reviewboard.asterisk.org/r/2572/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of the 6 implemented interfaces with curl and wscat to ensure bridge-related messages are delivered when appropriate.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130604/d1141a27/attachment.htm>