[asterisk-dev] [Code Review] 2544: Refactor CEL channel events on top of Stasis-Core

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2544/#review8774
-----------------------------------------------------------


I have no idea if the CEL stuffz is what it should be, but from a code perspective I didn't find many problems.


trunk/include/asterisk/stasis_channels.h
<https://reviewboard.asterisk.org/r/2544/#comment17246>

    Repeating yourself doesn't make it more true :-P



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2544/#comment17248>

    Unnecessary code.



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2544/#comment17249>

    This will always evaluate to true. I believe you wanted:
      if (snapshot->capabilities & (AST_BRIDGE_CAPABILITY_1TO1MIX | AST_BRIDGE_CAPABILITY_NATIVE))



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2544/#comment17250>

    You should unsubscribe_and_join() all these subscriptions.


- David Lee


On May 21, 2013, 5:03 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2544/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 5:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21563
>     https://issues.asterisk.org/jira/browse/ASTERISK-21563
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This uses the channel state change events from Stasis-Core to determine when channel-related CEL events should be raised. Those refactored in this patch are:
> * AST_CEL_CHANNEL_START
> * AST_CEL_ANSWER
> * AST_CEL_APP_START
> * AST_CEL_APP_END
> * AST_CEL_HANGUP
> * AST_CEL_CHANNEL_END
> 
> Retirement of Linked IDs is also refactored.
> 
> Note: Some HANGUP events are not generated correctly because the bridge layer does not propagate hangupcause/hangupsource information yet (there are already BUGBUGs for this).
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/config_options.h 389448 
>   trunk/include/asterisk/stasis_bridging.h 389448 
>   trunk/include/asterisk/stasis_channels.h 389448 
>   trunk/include/asterisk/strings.h 389448 
>   trunk/main/asterisk.c 389448 
>   trunk/main/cel.c 389448 
>   trunk/main/channel.c 389448 
>   trunk/main/config_options.c 389448 
>   trunk/main/pbx.c 389448 
>   trunk/main/stasis_bridging.c 389448 
>   trunk/main/stasis_channels.c 389448 
> 
> Diff: https://reviewboard.asterisk.org/r/2544/diff/
> 
> 
> Testing
> -------
> 
> Ran these changes through all integration tests that check CEL records.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130603/e794c177/attachment.htm>