[asterisk-dev] [Code Review] 2586: Refactor app_queue AMI events into stasis.

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2586/#review8778
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/2586/#comment17263>

    I wouldn't bother mentioning the stasis conversion, since the audience for the CHANGES file wouldn't care about that.
    
    Just "The AMI events in app_queue were made more consistent with each other"



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2586/#comment17266>

    I would also be fine with a STASIS_STATIC_MESSAGE_TYPE_DEFN() macro, but this works, too.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2586/#comment17265>

    These routes need to be removed on unload. I don't think there's a remove function on the router, but it should be relatively easy to add.


- David Lee


On May 31, 2013, 3:34 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2586/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 3:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21469
>     https://issues.asterisk.org/jira/browse/ASTERISK-21469
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Move app_queue AMI events to stasis.
> 
> Also removes eventwhencalled and eventmemberstatus, since it doesn't make sense (to me...) to keep them.
> 
> Renames Join/Leave to QueueCallerJoin/QueueCallerLeave.
> 
> Standardize many of the events, such as settling on a single way of displaying Interface/Location/Member/Whatever, and using channel snapshots where necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 390341 
>   /trunk/apps/app_queue.c 390341 
>   /trunk/configs/queues.conf.sample 390341 
>   /trunk/main/manager.c 390341 
> 
> Diff: https://reviewboard.asterisk.org/r/2586/diff/
> 
> 
> Testing
> -------
> 
> All of the events come out in the order they're supposed to.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130603/7c3b48d9/attachment-0001.htm>