[asterisk-dev] [Code Review] 2563: Refactor CEL bridge events on top of Stasis-Core

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2563/#review8776
-----------------------------------------------------------



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17251>

    1. Put a doxygen comment on this
    2. If capability is non-zero, will always return true. I believe you wanted:
      return (old->capabilities & new->capabilities & capability) == capability;



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17252>

    The ao2_callbacks should at least set OBJ_KEY, and bridge_match_cb should either test for it or assert on it.



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17253>

    Is this really necessary, since you test for capabilities below?



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17254>

    Similar capabilities checking problem as above.



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17255>

    Idem.



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17256>

    Idem.



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17257>

    Idem.



team/kmoore/bridge_construction-cel_channels/main/cel.c
<https://reviewboard.asterisk.org/r/2563/#comment17260>

    unsubscribe_and_join



team/kmoore/bridge_construction-cel_channels/main/parking.c
<https://reviewboard.asterisk.org/r/2563/#comment17259>

    register_cleanup


- David Lee


On May 23, 2013, 11:02 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2563/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 11:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21564
>     https://issues.asterisk.org/jira/browse/ASTERISK-21564
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This pulls bridge-related CEL event triggers out of the code in which they were residing and pulls them into cel.c where they are now triggered by changes in bridge snapshots. To get access to the Stasis-Core parking topic in cel.c, the Stasis-Core portions of parking init have been pulled into core Asterisk init.
> 
> This also adds a new CEL event (AST_CEL_BRIDGE_TO_CONF) that indicates a two-party bridge has transitioned to a multi-party conference.  The reverse cannot occur and two party bridges which receive a AST_CEL_BRIDGE_TO_CONF will be treated as multi-party conferences for the duration of the bridge.
> 
> 
> Diffs
> -----
> 
>   team/kmoore/bridge_construction-cel_channels/include/asterisk/cel.h 389549 
>   team/kmoore/bridge_construction-cel_channels/include/asterisk/_private.h 389549 
>   team/kmoore/bridge_construction-cel_channels/include/asterisk/parking.h 389549 
>   team/kmoore/bridge_construction-cel_channels/main/asterisk.c 389549 
>   team/kmoore/bridge_construction-cel_channels/main/cel.c 389549 
>   team/kmoore/bridge_construction-cel_channels/main/features.c 389549 
>   team/kmoore/bridge_construction-cel_channels/main/parking.c 389549 
>   team/kmoore/bridge_construction-cel_channels/res/parking/parking_manager.c 389549 
> 
> Diff: https://reviewboard.asterisk.org/r/2563/diff/
> 
> 
> Testing
> -------
> 
> Ran this through tests/bridge/simple_bridge (from the bridge_construction testsuite branch) and other tests that contain CEL conditions and tested parking messages by hand.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130603/7eec7dd8/attachment-0001.htm>