[asterisk-dev] [Code Review] 2583: Make ast_bridge_snapshot_to_json conform to the swagger Bridge model

[opticron]

> On June 3, 2013, 12:24 p.m., rmudgett wrote:
> > trunk/main/bridging.c, lines 6149-6151
> > <https://reviewboard.asterisk.org/r/2583/diff/1/?file=38901#file38901line6149>
> >
> >     I don't think there is much need for going from a string to a capability since there could be multiple capabilities.
> >     
> >     Also you are using case sensitive comparisons here.  Depending upon where the comparison string comes from this may be a problem.

The string -> capability function will be important when creating bridges via Stasis-HTTP.  I'll change it to a case-insensitive match.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2583/#review8767
-----------------------------------------------------------


On May 31, 2013, 1:42 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2583/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 1:42 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds two new fields to the JSON blob produced by ast_bridge_snapshot_to_json so that it conforms to the requirements of the JSON swagger model and reformulates the existing fields to be more swagger-friendly. This also exposes an existing capability to string function and introduces a companion conversion function.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/bridging.h 390290 
>   trunk/include/asterisk/stasis_bridging.h 390290 
>   trunk/main/bridging.c 390290 
>   trunk/main/stasis_bridging.c 390290 
>   trunk/rest-api/api-docs/bridges.json 390290 
> 
> Diff: https://reviewboard.asterisk.org/r/2583/diff/
> 
> 
> Testing
> -------
> 
> Made sure the messages came out right over Stasis-HTTP.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130603/d448bb62/attachment.htm>