[asterisk-dev] [Code Review] 2583: Make ast_bridge_snapshot_to_json conform to the swagger Bridge model

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2583/#review8767
-----------------------------------------------------------



trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2583/#comment17208>

    I don't think there is much need for going from a string to a capability since there could be multiple capabilities.
    
    Also you are using case sensitive comparisons here.  Depending upon where the comparison string comes from this may be a problem.


- rmudgett


On May 31, 2013, 6:42 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2583/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 6:42 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds two new fields to the JSON blob produced by ast_bridge_snapshot_to_json so that it conforms to the requirements of the JSON swagger model and reformulates the existing fields to be more swagger-friendly. This also exposes an existing capability to string function and introduces a companion conversion function.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/bridging.h 390290 
>   trunk/include/asterisk/stasis_bridging.h 390290 
>   trunk/main/bridging.c 390290 
>   trunk/main/stasis_bridging.c 390290 
>   trunk/rest-api/api-docs/bridges.json 390290 
> 
> Diff: https://reviewboard.asterisk.org/r/2583/diff/
> 
> 
> Testing
> -------
> 
> Made sure the messages came out right over Stasis-HTTP.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130603/711f1c9f/attachment.htm>