[asterisk-dev] [Code Review] 2698: ARI - implement allowMultiple for parameters

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2698/#review9242
-----------------------------------------------------------

Ship it!


Looks good to go.


/trunk/res/ari/resource_sounds.h
<https://reviewboard.asterisk.org/r/2698/#comment18226>

    I think you might have started working on some documentation here and then forgot to add it.


- jrose


On July 29, 2013, 10:12 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2698/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 10:12 p.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Swagger allows parameters to be specified as 'allowMultiple', meaning
> that the parameter may be specified as a comma separated list of
> values.
> 
> I had written some of the API docs using that, but promptly forgot
> about implementing it. This patch finally fills in that gap.
> 
> The codegen template was updated to represent 'allowMultiple' fields
> as array/size fields in the _args structs. It also parses the comma
> separated list using ast_app_separate_args(), so quoted strings in the
> argument will be handled properly.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/ari/resource_asterisk.h 395715 
>   /trunk/res/ari/resource_bridges.h 395715 
>   /trunk/res/ari/resource_bridges.c 395715 
>   /trunk/res/ari/resource_events.h 395715 
>   /trunk/res/ari/resource_events.c 395715 
>   /trunk/res/ari/resource_sounds.h 395715 
>   /trunk/res/res_ari_asterisk.c 395715 
>   /trunk/res/res_ari_bridges.c 395715 
>   /trunk/res/res_ari_channels.c 395715 
>   /trunk/res/res_ari_endpoints.c 395715 
>   /trunk/res/res_ari_events.c 395715 
>   /trunk/res/res_ari_playback.c 395715 
>   /trunk/res/res_ari_recordings.c 395715 
>   /trunk/res/res_ari_sounds.c 395715 
>   /trunk/rest-api-templates/ari_resource.h.mustache 395715 
>   /trunk/rest-api-templates/param_cleanup.mustache PRE-CREATION 
>   /trunk/rest-api-templates/param_parsing.mustache 395715 
>   /trunk/rest-api-templates/res_ari_resource.c.mustache 395715 
>   /trunk/rest-api/api-docs/bridges.json 395715 
>   /trunk/rest-api/api-docs/channels.json 395715 
>   /trunk/rest-api/api-docs/events.json 395715 
> 
> Diff: https://reviewboard.asterisk.org/r/2698/diff/
> 
> 
> Testing
> -------
> 
> Lots of variations hitting the events websocket and adding channels to
> bridges using comma separated lists.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130729/b749eb57/attachment.htm>