<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2698/">https://reviewboard.asterisk.org/r/2698/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to go.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2698/diff/2/?file=43002#file43002line44" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/res/ari/resource_sounds.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="cm">/*! \brief */</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">const</span> <span class="kt">char</span> <span class="o">*</span><span class="n">lang</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">const</span> <span class="kt">char</span> <span class="o">*</span><span class="n">lang</span><span class="p">;</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="cm">/*! \brief */</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you might have started working on some documentation here and then forgot to add it.</pre>
</div>
<br />
<p>- jrose</p>
<br />
<p>On July 29th, 2013, 10:12 p.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and jrose.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated July 29, 2013, 10:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Swagger allows parameters to be specified as 'allowMultiple', meaning
that the parameter may be specified as a comma separated list of
values.
I had written some of the API docs using that, but promptly forgot
about implementing it. This patch finally fills in that gap.
The codegen template was updated to represent 'allowMultiple' fields
as array/size fields in the _args structs. It also parses the comma
separated list using ast_app_separate_args(), so quoted strings in the
argument will be handled properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lots of variations hitting the events websocket and adding channels to
bridges using comma separated lists.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/ari/resource_asterisk.h <span style="color: grey">(395715)</span></li>
<li>/trunk/res/ari/resource_bridges.h <span style="color: grey">(395715)</span></li>
<li>/trunk/res/ari/resource_bridges.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/ari/resource_events.h <span style="color: grey">(395715)</span></li>
<li>/trunk/res/ari/resource_events.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/ari/resource_sounds.h <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_asterisk.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_bridges.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_channels.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_endpoints.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_events.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_playback.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_recordings.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_ari_sounds.c <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api-templates/ari_resource.h.mustache <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api-templates/param_cleanup.mustache <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/rest-api-templates/param_parsing.mustache <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api-templates/res_ari_resource.c.mustache <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api/api-docs/bridges.json <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api/api-docs/channels.json <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api/api-docs/events.json <span style="color: grey">(395715)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2698/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>