[asterisk-dev] [Code Review] 2707: Reorganize SIP endpoint configuration structures

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2707/
-----------------------------------------------------------

Review request for Asterisk Developers and Joshua Colp.


Bugs: ASTERISK-22135
    https://issues.asterisk.org/jira/browse/ASTERISK-22135


Repository: Asterisk


Description
-------

For the most part, this constitutes moving and sometimes renaming fields in the ast_sip_endpoint structure. The idea is to better organize the data into relevant categories. In addition, fields in the ast_sip_endpoint that were not used (domain, aor, and registrations) have been removed.

The only place where I allowed scope to creep was in relation to authentication. I noticed a tendency to pass an array of auth section names and the number of elements as parameters to functions. I also noticed several functions that were outright copied between sip_configuration.c and res_sip_outbound_registration.c with regards to authentication. So I created an ast_sip_auth_array structure that is now used as a common parameter for functions, and a couple of functions for populating and destroying the contents of the structures.


Diffs
-----

  /trunk/channels/chan_gulp.c 395553 
  /trunk/include/asterisk/res_sip.h 395553 
  /trunk/res/res_sip.c 395553 
  /trunk/res/res_sip.exports.in 395553 
  /trunk/res/res_sip/sip_configuration.c 395553 
  /trunk/res/res_sip/sip_distributor.c 395553 
  /trunk/res/res_sip/sip_options.c 395553 
  /trunk/res/res_sip/sip_outbound_auth.c 395553 
  /trunk/res/res_sip_authenticator_digest.c 395553 
  /trunk/res/res_sip_caller_id.c 395553 
  /trunk/res/res_sip_diversion.c 395553 
  /trunk/res/res_sip_messaging.c 395553 
  /trunk/res/res_sip_mwi.c 395553 
  /trunk/res/res_sip_nat.c 395553 
  /trunk/res/res_sip_one_touch_record_info.c 395553 
  /trunk/res/res_sip_outbound_authenticator_digest.c 395553 
  /trunk/res/res_sip_outbound_registration.c 395553 
  /trunk/res/res_sip_pubsub.c 395553 
  /trunk/res/res_sip_sdp_rtp.c 395553 
  /trunk/res/res_sip_session.c 395553 

Diff: https://reviewboard.asterisk.org/r/2707/diff/


Testing
-------

Code compiles, modules still load.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130726/230d1fd0/attachment.htm>