<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2707/">https://reviewboard.asterisk.org/r/2707/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By Mark Michelson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22135">ASTERISK-22135</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the most part, this constitutes moving and sometimes renaming fields in the ast_sip_endpoint structure. The idea is to better organize the data into relevant categories. In addition, fields in the ast_sip_endpoint that were not used (domain, aor, and registrations) have been removed.
The only place where I allowed scope to creep was in relation to authentication. I noticed a tendency to pass an array of auth section names and the number of elements as parameters to functions. I also noticed several functions that were outright copied between sip_configuration.c and res_sip_outbound_registration.c with regards to authentication. So I created an ast_sip_auth_array structure that is now used as a common parameter for functions, and a couple of functions for populating and destroying the contents of the structures.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code compiles, modules still load.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_gulp.c <span style="color: grey">(395553)</span></li>
<li>/trunk/include/asterisk/res_sip.h <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip.exports.in <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip/sip_configuration.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip/sip_distributor.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip/sip_options.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip/sip_outbound_auth.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_authenticator_digest.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_caller_id.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_diversion.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_messaging.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_mwi.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_nat.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_one_touch_record_info.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_outbound_authenticator_digest.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_outbound_registration.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_pubsub.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_sdp_rtp.c <span style="color: grey">(395553)</span></li>
<li>/trunk/res/res_sip_session.c <span style="color: grey">(395553)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2707/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>