[asterisk-dev] [Code Review] 2659: Let the testsuite run outside of the Asterisk source

[Matt Jordan]

> On July 11, 2013, 4:12 p.m., opticron wrote:
> > /asterisk/trunk/runtests.py, lines 401-412
> > <https://reviewboard.asterisk.org/r/2659/diff/1/?file=41142#file41142line401>
> >
> >     Is there any reason not to remove this block entirely? Do we ever expect this to be a requirement again?

Yes, it should just be removed.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2659/#review9124
-----------------------------------------------------------


On July 5, 2013, 4:57 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2659/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 4:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> For a host of historical reasons, the Asterisk Test Suite used to have to run as a subdirectory inside of the Asterisk source.
> 
> This actually hasn't been needed for quite some time. I had thought that the buildoptions library still needed this but - as it turns out - buildoptions will check the installed Asterisk headers for the build options it needs to execute.
> 
> This patch removes the checks and updates the README. It also makes the buildoptions library raise an Exception if it couldn't find the header - this really is needed, as certain build options (such as TEST_FRAMEWORK) are needed for a large number of tests to execute.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/README.txt 3880 
>   /asterisk/trunk/lib/python/asterisk/buildoptions.py 3880 
>   /asterisk/trunk/runtests.py 3880 
> 
> Diff: https://reviewboard.asterisk.org/r/2659/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130712/752ed193/attachment.htm>