[asterisk-dev] [Code Review] 2666: Allow SCOPED_* to be intermixed with declarations

David Lee reviewboard at asterisk.org
Thu Jul 11 09:28:15 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2666/
-----------------------------------------------------------

(Updated July 11, 2013, 9:28 a.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

It's a common error to mix SCOPED_LOCK (and friends) with variable
declarations.

Turns out that there's a very simple way to change SCOPED_LOCK so that
this isn't an error any more. While I feel silly posting a code review
for a one line change, I wanted to see if 1) are there any objections
to the change and 2) any objections to putting this in 11?


Diffs
-----

  /trunk/include/asterisk/lock.h 393828 

Diff: https://reviewboard.asterisk.org/r/2666/diff/


Testing
-------

It compiles.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130711/b1d8a7eb/attachment.htm>


More information about the asterisk-dev mailing list