[asterisk-dev] [Code Review] 2633: Filter channels used as internal mechanisms

opticron reviewboard at asterisk.org
Mon Jul 8 16:15:00 CDT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated July 8, 2013, 4:15 p.m.)

Review request for Asterisk Developers.


Update for Matt's and Joshua's comments.

Bugs: ASTERISK-21873

Repository: Asterisk

Description (updated)

This adds new flags to the channel tech properties that flag it as different types of implementation detail used exclusively to provide a feature. Examples of channels that would have these flags include the announcement and recording channels used by confbridge which are the only two marked as such by this patch.

A lot of this ended up being cleanup to ensure callers of various functions could handle a NULL return.

Diffs (updated)

  trunk/apps/confbridge/conf_chan_announce.c 393843 
  trunk/apps/confbridge/conf_chan_record.c 393843 
  trunk/apps/confbridge/confbridge_manager.c 393843 
  trunk/include/asterisk/channel.h 393843 
  trunk/include/asterisk/stasis_channels.h 393843 
  trunk/main/cdr.c 393843 
  trunk/main/cel.c 393843 
  trunk/main/manager_bridging.c 393843 
  trunk/main/manager_channels.c 393843 
  trunk/main/stasis_channels.c 393843 
  trunk/res/parking/parking_manager.c 393843 

Diff: https://reviewboard.asterisk.org/r/2633/diff/


Ran through CDR unit tests.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130708/ea548e2a/attachment-0001.htm>

More information about the asterisk-dev mailing list