[asterisk-dev] [Code Review] 2611: Refactor skinny sessions

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2611/#review9109
-----------------------------------------------------------

Ship it!


ao2 objects are pretty awesome and handy - I'm not sure what I'd do without em :-)

If you need any help with them, don't hesitate to ping someone on the -dev list or in IRC

- Matt Jordan


On July 6, 2013, 11:07 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2611/
> -----------------------------------------------------------
> 
> (Updated July 6, 2013, 11:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Refactor and cleanup of skinny session handling. Major changes are to pull all packet reading functions into skinny_session and move timeout handling to scheduling arrangements. Thread cancelling is now undertaken directly rather than waiting for the read to timeout (cleanup is popped on thread cancel). Also added some keepalive timings in debugging messages.
> 
> Also, keepalive timeout has been increased from 1.1 by keepalive to 3 times keepalive. This seems to align (after keepalives stabilise) with when devices reset after not receiving keepalives. Probably needs more work, especially around the first and/or second keepalives that vary significantly by device and firmware version.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 393775 
> 
> Diff: https://reviewboard.asterisk.org/r/2611/diff/
> 
> 
> Testing
> -------
> 
> Ongoing. Generally seems better and less issues with a graceful shutdown.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130710/9c0b9480/attachment.htm>