[asterisk-dev] [Code Review] 2611: Refactor skinny sessions

[wedhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2611/
-----------------------------------------------------------

(Updated July 6, 2013, 11:07 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated diff addressing Matt's issues.

Regarding the ao2 suggestion, I will look at moving the skinnysession stuff (and other skinny structures) to ao2 objects in the future. Just need the time to get my head around ao2 first.


Repository: Asterisk


Description
-------

Refactor and cleanup of skinny session handling. Major changes are to pull all packet reading functions into skinny_session and move timeout handling to scheduling arrangements. Thread cancelling is now undertaken directly rather than waiting for the read to timeout (cleanup is popped on thread cancel). Also added some keepalive timings in debugging messages.

Also, keepalive timeout has been increased from 1.1 by keepalive to 3 times keepalive. This seems to align (after keepalives stabilise) with when devices reset after not receiving keepalives. Probably needs more work, especially around the first and/or second keepalives that vary significantly by device and firmware version.


Diffs (updated)
-----

  /trunk/channels/chan_skinny.c 393775 

Diff: https://reviewboard.asterisk.org/r/2611/diff/


Testing
-------

Ongoing. Generally seems better and less issues with a graceful shutdown.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130706/85e22bc7/attachment.htm>