[asterisk-dev] [Code Review] 2665: Make SCOPED_LOCK use RAII_VAR directly

svnbot reviewboard at asterisk.org
Tue Jul 9 16:40:45 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2665/
-----------------------------------------------------------

(Updated July 9, 2013, 4:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 393919


Repository: Asterisk


Description
-------

SCOPED_LOCK is a multi-line macro, which means that SCOPED_LOCK had to be after (all?) other declarations in a function.  This patch changes that.  Using ({ }) magic would have probably been enough, but it just uses RAII_VAR now, since that's exactly what the code did already.


Diffs
-----

  /trunk/include/asterisk/lock.h 393824 

Diff: https://reviewboard.asterisk.org/r/2665/diff/


Testing
-------

Asterisk starts and stops.  A call through chan_sip didn't cause a deadlock.


Thanks,

Jason Parker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130709/57f12b56/attachment.htm>


More information about the asterisk-dev mailing list