[asterisk-dev] [Code Review] 2665: Make SCOPED_LOCK use RAII_VAR directly

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2665/#review9095
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On July 8, 2013, 6:33 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2665/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 6:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> SCOPED_LOCK is a multi-line macro, which means that SCOPED_LOCK had to be after (all?) other declarations in a function.  This patch changes that.  Using ({ }) magic would have probably been enough, but it just uses RAII_VAR now, since that's exactly what the code did already.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/lock.h 393824 
> 
> Diff: https://reviewboard.asterisk.org/r/2665/diff/
> 
> 
> Testing
> -------
> 
> Asterisk starts and stops.  A call through chan_sip didn't cause a deadlock.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130708/36ecc584/attachment.htm>