[asterisk-dev] [Code Review] 2658: Add transfer support to CEL

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2658/
-----------------------------------------------------------

(Updated July 9, 2013, 2:33 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed issues, added functionality and test for call pickup, and did some other cleanup.


Bugs: ASTERISK-21565
    https://issues.asterisk.org/jira/browse/ASTERISK-21565


Repository: Asterisk


Description (updated)
-------

This adds CEL support for blind and attended transfers and call pickup. During the course of adding this functionality I noticed that CONF_ENTER, CONF_EXIT, and BRIDGE_TO_CONF events are particularly useless without a bridge identifier, so I added that as well.

This adds tests for blind transfers, several types of attended transfers, and call pickup.

The extra field in CEL records now consists of a JSON blob whose fields are defined on a per-event basis.


Diffs (updated)
-----

  trunk/CHANGES 393895 
  trunk/apps/app_celgenuserevent.c 393895 
  trunk/apps/app_dial.c 393895 
  trunk/apps/app_directed_pickup.c 393895 
  trunk/apps/app_queue.c 393895 
  trunk/channels/chan_dahdi.c 393895 
  trunk/channels/chan_sip.c 393895 
  trunk/channels/sig_analog.c 393895 
  trunk/include/asterisk/cel.h 393895 
  trunk/main/cel.c 393895 
  trunk/main/channel.c 393895 
  trunk/main/features.c 393895 
  trunk/main/pbx.c 393895 
  trunk/tests/test_cel.c 393895 

Diff: https://reviewboard.asterisk.org/r/2658/diff/


Testing (updated)
-------

This passes all the CEL unit tests.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130709/be378e27/attachment-0001.htm>