[asterisk-dev] [Code Review] 2658: Add transfer support to CEL

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2658/#review9076
-----------------------------------------------------------



trunk/CHANGES
<https://reviewboard.asterisk.org/r/2658/#comment17841>

    I think you need to define how this is packed into the extra string.
    
    Preferably, the extra string would provide this information in some predictable fashion, i.e., key value pairs, or something else that is easily parsable across events that push data in the 'extra' field.



trunk/include/asterisk/cel.h
<https://reviewboard.asterisk.org/r/2658/#comment17836>

    Hooray for events that were never raised.



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2658/#comment17837>

    Check for allocation failure of the string.



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2658/#comment17838>

    And check for allocation failure of this string



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2658/#comment17839>

    And this string too


- Matt Jordan


On July 4, 2013, 3:24 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2658/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 3:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21565
>     https://issues.asterisk.org/jira/browse/ASTERISK-21565
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds CEL support for blind and attended transfers. During the course of adding this functionality I noticed that CONF_ENTER, CONF_EXIT, and BRIDGE_TO_CONF events are particularly useless without a bridge identifier, so I added that as well. This also adds tests for blind transfers and several types of attended transfers.
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 393700 
>   trunk/include/asterisk/cel.h 393700 
>   trunk/main/cel.c 393700 
>   trunk/tests/test_cel.c 393700 
> 
> Diff: https://reviewboard.asterisk.org/r/2658/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130704/10cdd7b7/attachment-0001.htm>