[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[Joshua Colp]

> On July 8, 2013, 9:43 p.m., rmudgett wrote:
> > /trunk/main/bridging.c, line 64
> > <https://reviewboard.asterisk.org/r/2636/diff/3/?file=40440#file40440line64>
> >
> >     I don't think this still needs to be included.

Someone else is now including this, not touching it.


> On July 8, 2013, 9:43 p.m., rmudgett wrote:
> > /trunk/main/bridging.c, lines 2599-2606
> > <https://reviewboard.asterisk.org/r/2636/diff/3/?file=40440#file40440line2599>
> >
> >     The chan_target channel needs COLP update here so the person connected to chan_bridged will get correct COLP information.  The chan_bridged channel is masquerading into an application channel like voicemail.

As this performs a masquerade internally the bridge will be notified a masquerade occurred, and as a result a COLP update is performed.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/#review9096
-----------------------------------------------------------


On June 26, 2013, 5:16 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 5:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21829
>     https://issues.asterisk.org/jira/browse/ASTERISK-21829
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).
> 
> Old code which is no longer required has also been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 392646 
>   /trunk/main/bridging.c 392646 
>   /trunk/main/channel.c 392646 
> 
> Diff: https://reviewboard.asterisk.org/r/2636/diff/
> 
> 
> Testing
> -------
> 
> Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).
> 
> Calling, transfers, etc.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130709/f8a69a5b/attachment.htm>