[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/#review9096
-----------------------------------------------------------



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17914>

    I don't think this still needs to be included.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17917>

    Zombies and hungup channels should skip COLP updates as well.  No point in them.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17911>

    Delete this function.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17912>

    Revert all changes with this function.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17913>

    Revert all changes with this function.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17920>

    The chan_target channel needs COLP update here so the person connected to chan_bridged will get correct COLP information.  The chan_bridged channel is masquerading into an application channel like voicemail.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17915>

    This will work just fine if you don't use the interception macro/subroutines.  The point of the interception routines is to manipulate the COLP information.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17916>

    A COLP update should happen here because a masquerade changed the channel's guts.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17918>

    Should do the same to both bridges.  The source bridge is most likely going to be empty, so a COLP update won't do anything.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17919>

    Same here.


- rmudgett


On June 26, 2013, 5:16 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 5:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21829
>     https://issues.asterisk.org/jira/browse/ASTERISK-21829
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).
> 
> Old code which is no longer required has also been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 392646 
>   /trunk/main/bridging.c 392646 
>   /trunk/main/channel.c 392646 
> 
> Diff: https://reviewboard.asterisk.org/r/2636/diff/
> 
> 
> Testing
> -------
> 
> Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).
> 
> Calling, transfers, etc.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130708/03218ff8/attachment-0001.htm>