[asterisk-dev] [Code Review] 2645: Use stasis cache in more places

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2645/
-----------------------------------------------------------

(Updated July 7, 2013, 7:30 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-21883
    https://issues.asterisk.org/jira/browse/ASTERISK-21883


Repository: Asterisk


Description
-------

This change moves CLI/AGI/AMI commands to accessing the Stasis cache for retrieving information instead of directly accessing the data structures. I have also added an AMI action to get bridge information, and extended the "status" action to include the same information available as "core show channel".

Stuff given up:
1. Number of frames being read and written
2. First file descriptor
3. What the channel is blocked in

An additional question:
I'm not currently storing channel trace information in the snapshot and as a result it is not displayed. Is this a feature we still want to support? How widespread is it?


Diffs (updated)
-----

  /trunk/include/asterisk/channel.h 393775 
  /trunk/include/asterisk/stasis_channels.h 393775 
  /trunk/main/bridging.c 393775 
  /trunk/main/channel.c 393775 
  /trunk/main/channel_internal_api.c 393775 
  /trunk/main/cli.c 393775 
  /trunk/main/manager.c 393775 
  /trunk/main/manager_bridging.c 393775 
  /trunk/main/manager_channels.c 393775 
  /trunk/main/pbx.c 393775 
  /trunk/main/stasis_channels.c 393775 
  /trunk/res/res_agi.c 393775 

Diff: https://reviewboard.asterisk.org/r/2645/diff/


Testing
-------

Executed the changed CLI commands, AMI actions, and AGI commands and ensured that the output is as expected.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130707/af5f9fcc/attachment.htm>