[asterisk-dev] [Code Review] 2645: Use stasis cache in more places

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2645/#review9083
-----------------------------------------------------------



/trunk/main/manager_channels.c
<https://reviewboard.asterisk.org/r/2645/#comment17883>

    So, Kinsey is right that we update what is sent over AMI with all this information, we also have to update the documentation for everything that has a prefix.
    
    Up to you which way you want to go - but I don't think we *have* to convey this information over AMI. It may be nice to, but it may also not be that necessary. If we do convey it though, we are going to have to update all of the documentation.



/trunk/main/manager_channels.c
<https://reviewboard.asterisk.org/r/2645/#comment17882>

    I'm not sure we get much value by having the callid conveyed over AMI - and probably over the snapshots as well.
    
    The callid is currently only available in the Asterisk logs, and has not relevance outside of them. That may change someday, but until it does, I'm a bit concerned that someone will start to depend on the semantics of them - which are only loosely defined in certain complex scenarios.


- Matt Jordan


On July 2, 2013, 11:04 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2645/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 11:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21883
>     https://issues.asterisk.org/jira/browse/ASTERISK-21883
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves CLI/AGI/AMI commands to accessing the Stasis cache for retrieving information instead of directly accessing the data structures. I have also added an AMI action to get bridge information, and extended the "status" action to include the same information available as "core show channel".
> 
> Stuff given up:
> 1. Number of frames being read and written
> 2. First file descriptor
> 3. What the channel is blocked in
> 
> An additional question:
> I'm not currently storing channel trace information in the snapshot and as a result it is not displayed. Is this a feature we still want to support? How widespread is it?
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 393517 
>   /trunk/include/asterisk/stasis_channels.h 393517 
>   /trunk/main/bridging.c 393517 
>   /trunk/main/channel.c 393517 
>   /trunk/main/channel_internal_api.c 393517 
>   /trunk/main/cli.c 393517 
>   /trunk/main/manager.c 393517 
>   /trunk/main/manager_bridging.c 393517 
>   /trunk/main/manager_channels.c 393517 
>   /trunk/main/pbx.c 393517 
>   /trunk/main/stasis_channels.c 393517 
>   /trunk/res/res_agi.c 393517 
> 
> Diff: https://reviewboard.asterisk.org/r/2645/diff/
> 
> 
> Testing
> -------
> 
> Executed the changed CLI commands, AMI actions, and AGI commands and ensured that the output is as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130706/945f3754/attachment-0001.htm>