[asterisk-dev] [Code Review]: Adds variable length callinfo packets to skinny

[wedhorn]

> On Jan. 25, 2013, 8:12 a.m., opticron wrote:
> > /trunk/channels/chan_skinny.c, lines 1091-1095
> > <https://reviewboard.asterisk.org/r/2290/diff/2/?file=33078#file33078line1091>
> >
> >     I'd prefer to see it documented what these are even if they're currently unusable if the information is available.  If not, what's here is fine.

We've no idea of what these are. Can guess that a couple are redirection reasons, but don't know which ones.


> On Jan. 25, 2013, 8:12 a.m., opticron wrote:
> > /trunk/channels/chan_skinny.c, line 2485
> > <https://reviewboard.asterisk.org/r/2290/diff/2/?file=33078#file33078line2485>
> >
> >     Is there any reason that the variable call info message should not be sent from push_callinfo for protocol versions >= 17 as well?

Woops. Added in new diff.


- wedhorn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2290/#review7742
-----------------------------------------------------------


On Jan. 25, 2013, 1:16 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2290/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 1:16 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Add packet 0x014A (variable length call info messages) to skinny for newer firmware. Plenty of unknown information but includes the equivalent functionality as the fixed size callinfo packet already included.
> 
> Only send this packet if protocol reported is >= 17.
> 
> 
> This addresses bug ASTERISK-20965.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20965
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 380057 
> 
> Diff: https://reviewboard.asterisk.org/r/2290/diff
> 
> 
> Testing
> -------
> 
> Made in/out/missed calls on v17 phone, correct info displayed on call and on device call logs. Checked that the old callinfo is still used when protocol is <17.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130125/930381e5/attachment-0001.htm>