[asterisk-dev] [Code Review] Adds variable length callinfo packets to skinny

[wedhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2290/
-----------------------------------------------------------

(Updated Jan. 25, 2013, 1:16 p.m.)


Review request for Asterisk Developers and Brad Latus.


Changes
-------

Added use of v17 callinfo to push_callinfo.


Summary
-------

Add packet 0x014A (variable length call info messages) to skinny for newer firmware. Plenty of unknown information but includes the equivalent functionality as the fixed size callinfo packet already included.

Only send this packet if protocol reported is >= 17.


This addresses bug ASTERISK-20965.
    https://issues.asterisk.org/jira/browse/ASTERISK-20965


Diffs (updated)
-----

  /trunk/channels/chan_skinny.c 380057 

Diff: https://reviewboard.asterisk.org/r/2290/diff


Testing
-------

Made in/out/missed calls on v17 phone, correct info displayed on call and on device call logs. Checked that the old callinfo is still used when protocol is <17.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130125/7a0d8a68/attachment.htm>