[asterisk-dev] [Code Review] add queue pause device states for queue member/queues

[lathama]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2254/#review7688
-----------------------------------------------------------


I took a quick look at the code.  Could you add some Doxygen or other comments and use the standard comment tags instead of //.

- lathama


On Dec. 27, 2012, 12:46 p.m., p_lindheimer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2254/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 12:46 p.m.)
> 
> 
> Review request for Asterisk Developers and p_lindheimer.
> 
> 
> Summary
> -------
> 
> Add a Queue Pause Device State that allows hints to be generated and thus useful BLF buttons on phones. The format is:
> 
> qpause:qname:agent
> 
> so an example hint that could be made from this, for agent 702 (Local) in queue 434 would look like this:
> 
> exten => *46*702*434,hint,qpause:434:Local/702 at from-queue/n
> 
> This has been implemented in FreePBX 2.11 (currently in beta) and is required for full functionality, it has been tested using version 11 and 10 and the patch is included on the version of Asterisk included in the FreePBX Distro for both versions 10 and 11.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 378206 
> 
> Diff: https://reviewboard.asterisk.org/r/2254/diff
> 
> 
> Testing
> -------
> 
> tested on latest versions 10 and 11 using FreePBX 2.11
> 
> 
> Thanks,
> 
> p_lindheimer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/18c3090b/attachment.htm>