[asterisk-dev] [Code Review]: Fix SIP Notify Messages To Have The Proper IP Address In The FROM Field

[elguero]

> On Jan. 3, 2013, 6:59 a.m., jcolp wrote:
> > /branches/1.8/channels/chan_sip.c, lines 7988-7990
> > <https://reviewboard.asterisk.org/r/2255/diff/1/?file=32500#file32500line7988>
> >
> >     Was adding this debug useful?

I thought that it was helpful.  When looking at the debug log, I could see that the call-id was set and then I could see when the call-id was changed and what it was changed to.  It was a nice way of confirming that things were working properly and I thought it would be beneficial for tracking a call by the call-id for future troubleshooting.

If you think it should be removed, it can be done.  I just thought it might be helpful to have since we do see in the logs that the call-id is set and what it is set to but never when the call-id was changed.


> On Jan. 3, 2013, 6:59 a.m., jcolp wrote:
> > /branches/1.8/channels/chan_sip.c, line 19591
> > <https://reviewboard.asterisk.org/r/2255/diff/1/?file=32500#file32500line19591>
> >
> >     You can remove this comment, it's already mentioned above.

Okay... done.


- elguero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2255/#review7596
-----------------------------------------------------------


On Dec. 29, 2012, 9:34 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2255/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 9:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> On a multihomed server, when sending a NOTIFY message we are not figuring out which network should be used to contact the peer that the message is going to.
> 
> This patch fixes the problem by calling ast_sip_ouraddrfor() and then build_via() so that our NOTIFY message contains the correct IP address.
> 
> 
> This addresses bug ASTERISK-20805.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20805
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 378070 
> 
> Diff: https://reviewboard.asterisk.org/r/2255/diff
> 
> 
> Testing
> -------
> 
> Tested on dev box and the reporter also tested it in his environment.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130103/34a355fe/attachment-0001.htm>