[asterisk-dev] [Code Review] Fix SIP Notify Messages To Have The Proper IP Address In The FROM Field

[jcolp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2255/#review7596
-----------------------------------------------------------

Ship it!


Some minor comments, it shouldn't prevent it from going in.


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2255/#comment14476>

    Was adding this debug useful?



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2255/#comment14475>

    You can remove this comment, it's already mentioned above.


- jcolp


On Dec. 29, 2012, 9:34 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2255/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 9:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> On a multihomed server, when sending a NOTIFY message we are not figuring out which network should be used to contact the peer that the message is going to.
> 
> This patch fixes the problem by calling ast_sip_ouraddrfor() and then build_via() so that our NOTIFY message contains the correct IP address.
> 
> 
> This addresses bug ASTERISK-20805.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20805
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 378070 
> 
> Diff: https://reviewboard.asterisk.org/r/2255/diff
> 
> 
> Testing
> -------
> 
> Tested on dev box and the reporter also tested it in his environment.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130103/96067a68/attachment-0001.htm>