[asterisk-dev] [Code Review] This patch adds externaddr per trunk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2345/#review7941
-----------------------------------------------------------


The latest diff is not displaying chan_sip properly. It appears that you provided a malformed diff. The easiest way to submit a patch to reviewboard is to use the post-review script that is a part of RBTools. You can find instructions on how to use it on the wiki here: https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage

Once you have the script installed, you should be able to run

post-review -r 2345

And then come to this page and publish the new diff. Lately I've noticed that the post-review tool may not work on the first few tries for some reason, but if you keep at it, it will eventually work.

- Mark


On Feb. 22, 2013, 4:50 p.m., jozza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2345/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2013, 4:50 p.m.)
> 
> 
> Review request for Asterisk Developers and leifmadsen.
> 
> 
> Summary
> -------
> 
> Read latest comments on bugs page
> 
> 
> This addresses bug ASTERISK-18643.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18643
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 380806 
>   /trunk/channels/chan_sip.c 380806 
>   /trunk/channels/sip/include/sip.h 380806 
> 
> Diff: https://reviewboard.asterisk.org/r/2345/diff
> 
> 
> Testing
> -------
> 
> tested for 1.6 works fine, untested for trunk, should work
> 
> 
> Thanks,
> 
> jozza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130225/d1d3efa5/attachment.htm>