<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2345/">https://reviewboard.asterisk.org/r/2345/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The latest diff is not displaying chan_sip properly. It appears that you provided a malformed diff. The easiest way to submit a patch to reviewboard is to use the post-review script that is a part of RBTools. You can find instructions on how to use it on the wiki here: https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage
Once you have the script installed, you should be able to run
post-review -r 2345
And then come to this page and publish the new diff. Lately I've noticed that the post-review tool may not work on the first few tries for some reason, but if you keep at it, it will eventually work.</pre>
<br />
<p>- Mark</p>
<br />
<p>On February 22nd, 2013, 4:50 p.m., jozza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and leifmadsen.</div>
<div>By jozza.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2013, 4:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Read latest comments on bugs page</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested for 1.6 works fine, untested for trunk, should work</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18643">ASTERISK-18643</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(380806)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(380806)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(380806)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2345/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>