[asterisk-dev] [Code Review] Restore default_user and default_bridge profiles in ConfBridge when their sections are removed from the config file

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2356/#review7933
-----------------------------------------------------------

Ship it!


The only things I can think of that would be good to add are documentation-related. It should be clear that even if there is no default user or bridge profile specified in the configuration that it exists internally. I also suggest issuing a NOTICE-level message if you have to generate a default user or bridge profile. Otherwise, If someone were to delete the default user profile, for example, it might seem a bit strange that if they issue a "confbridge show profile users" they'll still see the default listed.

- Mark


On Feb. 25, 2013, 10:16 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2356/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 10:16 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The confbridge sample configuration file has the following to say about the default user/bridge profiles:
> 
> ; --- Default Information ---
> ; The default_user and default_bridge sections are applied
> ; automatically to all ConfBridge instances invoked without
> ; a user, or bridge argument.  No menu is applied by default.
> ;
> 
> These always have to exist: while they can be specified in the conf file and their default values overriden, removing them from the conf file should not remove them from ConfBridge - it has to have a default profile to apply to bridges/users, otherwise it doesn't know what to do with them when you fail to specify a profile. What's more, applications such as Page (which use ConfBridge under the hood) have no mechanism to supply a bridge profile to build on, resulting in errors.
> 
> This patch restores the behavior prior to the configuration re-work that went in for ConfBridge for Asterisk 11. It ensures that if the conf file processed does not provide a default bridge/user profile, that the objects are created and populated with their default values appropriately.
> 
> 
> Diffs
> -----
> 
>   /branches/11/apps/confbridge/conf_config_parser.c 382055 
> 
> Diff: https://reviewboard.asterisk.org/r/2356/diff
> 
> 
> Testing
> -------
> 
> Removed the default_bridge/default_user profiles from the configuration file. Started Asterisk, CLI command successfully showed that the default profiles existed in memory with the appropriate values.
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130225/394c3e2f/attachment-0001.htm>