[asterisk-dev] [Code Review] Add Path header support to chan_sip

Olle E Johansson reviewboard at asterisk.org
Sun Feb 24 03:48:14 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 24, 2013, 3:48 a.m.)

Review request for Asterisk Developers and Klaus Darilion.


This is continued development based on https://reviewboard.asterisk.org/r/991/ by Klaus Darillion

In that review Klaus wrote:
"This patch adds support for the Parse header (RFC 3327). This allows to record the Path (route) of incoming REGISTER requests and then reuse the learned path on outgoing out-of-dialog requests as a pre-loaded route set.

I tried to reuse as much of existing code as possible. There are several parts where I am not sure if it is implemented nice and follow chan_sip design rules (are there any?) I will post my questions as a review to myself."

I have added realtime support and the global flags, as well as some other minor fixes. The bulk of this code is still Klaus' work.

This addresses bug ASTERISK-16884.

Diffs (updated)

  /trunk/CHANGES 381912 
  /trunk/CREDITS 381912 
  /trunk/channels/chan_sip.c 381912 
  /trunk/channels/sip/include/sip.h 381912 
  /trunk/configs/res_ldap.conf.sample 381912 
  /trunk/configs/sip.conf.sample 381912 
  /trunk/contrib/realtime/mysql/sippeers.sql 381912 
  /trunk/contrib/realtime/postgresql/realtime.sql 381912 
  /trunk/contrib/scripts/asterisk.ldap-schema 381912 
  /trunk/contrib/scripts/asterisk.ldif 381912 

Diff: https://reviewboard.asterisk.org/r/2235/diff


I have this patch running with and without NAT, but not with realtime. Will test, but have also asked for testers on asterisk-dev. Need help with the LDAP schemas.


Olle E

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130224/166a15b6/attachment.htm>

More information about the asterisk-dev mailing list