[asterisk-dev] pjproject review (code.asterisk.org), support shared libraries.

[Paul Belanger]

On 13-02-19 02:50 PM, Jason Parker wrote:
> On 02/13/2013 11:30 AM, Jason Parker wrote:
>> Since our version of Review Board doesn't properly support git repos,
>> I'm having
>> to use Crucible for this - please bear with me.  If you have any trouble
>> reviewing things on there, let Matt Jordan (Matt, watch out for the
>> bus!) or I
>> know, and we can try to fix things up.
>>
>>
>> As part of the effort towards building proper packages for pjproject,
>> I was
>> tasked with adding support for shared libraries.
>>
>> Libraries build and link.  Binaries execute.  Installation works
>> (other than
>> potentially missing an ldconfig).
>>
>> The entirety of this review consists of build system changes.  Here be
>> dragons.
>>
>> Review:
>>      https://code.asterisk.org/code/cru/CR-AST-12
>>
>> (For testing purposes, this code currently lives in the
>> patch/shared-libraries
>> branch on git://github.com/asterisk/pjproject.git)
>>
> There is now a branch of Asterisk [1] that this can be used with, if
> that was a holdup for reviews.  pjproject has been removed from the tree
> here, and it now depends on shared libraries.
>
> [1] https://origsvn.digium.com/svn/asterisk/team/qwell/pjsip-shared-libs/
>
How are we dealing with feedback from pjproject developers?  I'm not 
sure many of them monitor our lists.  Might be worth reaching out to 
them as another source of testers.

-- 
Paul Belanger | PolyBeacon, Inc.
Jabber: paul.belanger at polybeacon.com | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter: 
https://twitter.com/pabelanger