[asterisk-dev] [Code Review] Add The Status Of A Module To The Output Of "CLI> module show"

elguero reviewboard at asterisk.org
Tue Feb 19 10:52:46 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2331/
-----------------------------------------------------------

(Updated Feb. 19, 2013, 10:52 a.m.)


Review request for Asterisk Developers.


Changes
-------

Updated diff based on last review.


Summary
-------

When a module's configuration is not loadable, we still load the module itself but it is not in a running state.  When trying to troubleshoot, let's say, why chan_motif was ignoring inbound XMPP traffic, there is no way to indicate that a loaded module is not currently running.

This patch:
* Adds a column that will show the status of the module

Module                         Description                              Use Count  Status
res_xmpp.so                    Asterisk XMPP Interface                  0          Running

Module                         Description                              Use Count  Status
chan_motif.so                  Motif Jingle Channel Driver              0          Not Running


This addresses bug ASTERISK-21108.
    https://issues.asterisk.org/jira/browse/ASTERISK-21108


Diffs (updated)
-----

  /trunk/channels/chan_motif.c 381715 
  /trunk/include/asterisk/module.h 381715 
  /trunk/main/cli.c 381715 
  /trunk/main/loader.c 381715 
  /trunk/res/snmp/agent.c 381715 

Diff: https://reviewboard.asterisk.org/r/2331/diff


Testing
-------

Tested this on dev box.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130219/5f2e6d0f/attachment-0001.htm>


More information about the asterisk-dev mailing list