[asterisk-dev] [Code Review]: Add The Status Of A Module To The Output Of "CLI> module show"

[elguero]

> On Feb. 16, 2013, 2:09 p.m., Sean Bright wrote:
> > Looks good - a few notes below.  This breaks ABI compatibility so maybe a note in UPGRADE is necessary too.
> 
> rmudgett wrote:
>     The note is not necessary for trunk patches.
>     
>     Also there is a compile error in agent.c.
>     The agent.c:countmodule() function needs to be updated with new ast_update_module_list() callback signature to compile.

Good catch on agent.c.  I didn't have res_snmp enabled and so that wasn't caught on my end.

Fixed


> On Feb. 16, 2013, 2:09 p.m., Sean Bright wrote:
> > /trunk/main/cli.c, lines 654-655
> > <https://reviewboard.asterisk.org/r/2331/diff/1/?file=33483#file33483line654>
> >
> >     "Not Running" is 11 characters.
> 
> rmudgett wrote:
>     Since this is the last column, just %s would suffice.

Doh.. I had 11 in there at one time.  Not sure why I changed it.

Changed to %s as suggested by Richard.


> On Feb. 16, 2013, 2:09 p.m., Sean Bright wrote:
> > /trunk/main/loader.c, line 1254
> > <https://reviewboard.asterisk.org/r/2331/diff/1/?file=33484#file33484line1254>
> >
> >     Wrap this line.

Done


- elguero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2331/#review7886
-----------------------------------------------------------


On Feb. 15, 2013, 11 a.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2331/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When a module's configuration is not loadable, we still load the module itself but it is not in a running state.  When trying to troubleshoot, let's say, why chan_motif was ignoring inbound XMPP traffic, there is no way to indicate that a loaded module is not currently running.
> 
> This patch:
> * Adds a column that will show the status of the module
> 
> Module                         Description                              Use Count  Status
> res_xmpp.so                    Asterisk XMPP Interface                  0          Running
> 
> Module                         Description                              Use Count  Status
> chan_motif.so                  Motif Jingle Channel Driver              0          Not Running
> 
> 
> This addresses bug ASTERISK-21108.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21108
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_motif.c 381426 
>   /trunk/include/asterisk/module.h 381426 
>   /trunk/main/cli.c 381426 
>   /trunk/main/loader.c 381426 
> 
> Diff: https://reviewboard.asterisk.org/r/2331/diff
> 
> 
> Testing
> -------
> 
> Tested this on dev box.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130219/5f1fe903/attachment.htm>