[asterisk-dev] [Code Review] Fixup skinny CLI completion

[Brad Latus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2333/#review7888
-----------------------------------------------------------


Looks good to me

- Brad


On Feb. 16, 2013, 4:58 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2333/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2013, 4:58 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Various fixups for skinny CLI completion.
> 
> Auto complete for skinny debug allows multiple options and negation, also add debug all option.
> Usage example: 'skinny debug all -packets' (each can be autocompleted including -packet).
> 
> Change show device to use device name. Remove the duplicate ast_strdup's from place calling device complete return immediately from complete devicename and complete linename so that multiple options are displayed on the CLI if more that one option available.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 381471 
> 
> Diff: https://reviewboard.asterisk.org/r/2333/diff
> 
> 
> Testing
> -------
> 
> Tried all the cli sequences I could think of. Works.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130218/03091ddb/attachment.htm>