[asterisk-dev] [Code Review] Fixup skinny CLI completion

wedhorn reviewboard at asterisk.org
Sat Feb 16 16:58:27 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2333/
-----------------------------------------------------------

(Updated Feb. 16, 2013, 4:58 p.m.)


Review request for Asterisk Developers and Brad Latus.


Changes
-------

Removed some blobs.


Summary
-------

Various fixups for skinny CLI completion.

Auto complete for skinny debug allows multiple options and negation, also add debug all option.
Usage example: 'skinny debug all -packets' (each can be autocompleted including -packet).

Change show device to use device name. Remove the duplicate ast_strdup's from place calling device complete return immediately from complete devicename and complete linename so that multiple options are displayed on the CLI if more that one option available.


Diffs (updated)
-----

  /trunk/channels/chan_skinny.c 381471 

Diff: https://reviewboard.asterisk.org/r/2333/diff


Testing
-------

Tried all the cli sequences I could think of. Works.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130216/e584a01f/attachment-0001.htm>


More information about the asterisk-dev mailing list