[asterisk-dev] [Code Review] Additional Sorcery Features

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2320/#review7822
-----------------------------------------------------------

Ship it!



/trunk/include/asterisk/sorcery.h
<https://reviewboard.asterisk.org/r/2320/#comment14840>

    I initially misread this as ast_sorcery_objectset_copy(), as in copying a sorcery objectset as opposed to setting the copy handler for a sorcery object.
    
    Maybe consider change the name to ast_sorcery_object_set_copy_handler()?
    
    Same thing for ast_sorcery_object_set_diff().


- Mark


On Feb. 7, 2013, 12:56 p.m., jcolp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2320/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 12:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using sorcery in the new SIP infrastructure has uncovered a few areas where some additional sorcery features would be nice. I've implemented them, and then some!
> 
> First up is that there are two new API calls which allow a specific object type to be loaded or reloaded. This is useful for modules that extend an existing sorcery with their own object types and want to load only those upon being loaded themselves.
> 
> Second is two callbacks to allow native object copying and diffing. This is useful for performances reasons when you don't want to incur the translation from native type to key value pair. These callbacks are optional and if they aren't used the existing generic key value pair mechanism is used.
> 
> I've also added unit tests for the native copy and diff callbacks.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/sorcery.h 381035 
>   /trunk/main/sorcery.c 381035 
>   /trunk/tests/test_sorcery.c 381035 
> 
> Diff: https://reviewboard.asterisk.org/r/2320/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests to confirm functionality.
> 
> 
> Thanks,
> 
> jcolp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130208/52b4b34f/attachment.htm>