[asterisk-dev] [Code Review] Adding Manager Events To ConfBridge For ConfbridgeMute, ConfbridgeUnmute, ConfbridgeStartRecord, ConfbridgeStopRecord

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2309/#review7810
-----------------------------------------------------------

Ship it!


Other than the minor improvement this looks good to go.


/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2309/#comment14826>

    There is no reason to use the ternary expression here.
    
    It is easier to see using the if statement.


- rmudgett


On Feb. 4, 2013, 10:44 a.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2309/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2013, 10:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, ConfBridge does not send manager events for ConfbridgeMute, ConfbridgeUnmute, ConfbridgeStartRecord and ConfbridgeStopRecord.  The proposed patch adds these events.
> 
> The reporter's patch moves some other events up to the beginning of the file.
> 
> The patch being posted for review here is based on the patch contributed from the reporter of this issue.  I have made a lot of modifications to the patch in order for it to fit in better with what we currently are doing in the code when it comes to manager events.  I also made a few changes to the <see-also> elements on some of the events.
> 
> 
> This addresses bug ASTERISK-20827.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20827
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 380806 
> 
> Diff: https://reviewboard.asterisk.org/r/2309/diff
> 
> 
> Testing
> -------
> 
> Tested this patch locally and confirmed that the events were being sent properly.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130207/e380aa18/attachment.htm>