[asterisk-dev] [Code Review] Adding Manager Events To ConfBridge For ConfbridgeMute, ConfbridgeUnmute, ConfbridgeStartRecord, ConfbridgeStopRecord

elguero reviewboard at asterisk.org
Mon Feb 4 10:44:50 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2309/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Currently, ConfBridge does not send manager events for ConfbridgeMute, ConfbridgeUnmute, ConfbridgeStartRecord and ConfbridgeStopRecord.  The proposed patch adds these events.

The reporter's patch moves some other events up to the beginning of the file.

The patch being posted for review here is based on the patch contributed from the reporter of this issue.  I have made a lot of modifications to the patch in order for it to fit in better with what we currently are doing in the code when it comes to manager events.  I also made a few changes to the <see-also> elements on some of the events.


This addresses bug ASTERISK-20827.
    https://issues.asterisk.org/jira/browse/ASTERISK-20827


Diffs
-----

  /trunk/apps/app_confbridge.c 380806 

Diff: https://reviewboard.asterisk.org/r/2309/diff


Testing
-------

Tested this patch locally and confirmed that the events were being sent properly.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130204/9c8a7727/attachment.htm>


More information about the asterisk-dev mailing list