[asterisk-dev] [Code Review] 3062: a systemd service

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3062/#review10499
-----------------------------------------------------------



/trunk/Makefile
<https://reviewboard.asterisk.org/r/3062/#comment19952>

    Would explicitly specifying /lib/ run afoul of the lib64 problem?
    
    Would it be better to specify $(libdir) instead?



/trunk/contrib/asterisk.service
<https://reviewboard.asterisk.org/r/3062/#comment19953>

    Should we specify PIDFile= here?
    
    Something like:
    
    PIDFile=${ASTVARRUNDIR}/asterisk.pid
    
    Although I imagine we would want the installation of the systemd service to do something along the lines of safe_asterisk, where ASTVARRUNDIR is replaced with the actual value of the run directory.



/trunk/contrib/asterisk.service
<https://reviewboard.asterisk.org/r/3062/#comment19956>

    Similarly to the ExecStopPost, it'd be nice - if not necessary - to have a pre-start script that checks the file descriptor/core file limits and set them to the system max/unlimited.



/trunk/contrib/asterisk.service
<https://reviewboard.asterisk.org/r/3062/#comment19954>

    Looking at how safe_asterisk spawns Asterisk, I'm not sure specifying an explicit run user is appropriate here. There's no guarantee that there's a user named "Asterisk" on the system.



/trunk/contrib/asterisk.service
<https://reviewboard.asterisk.org/r/3062/#comment19955>

    I think this patch should consider providing a basic stop post script that does what safe_asterisk performs with respect to core files at the very least. One of the most widely used and useful features is safe_asterisk's management of core files in the event of an Asterisk crash; it'd be nice to have that here as well.


- Matt Jordan


On Dec. 24, 2013, 10:49 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3062/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2013, 10:49 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Installs a systemd service file for Asterisk.
> 
> Systeemd is the new "one daemon to rule them all" for Linux: http://www.freedesktop.org/wiki/Software/systemd/
> On systems without systemd this should be just a harmless (though maybe annoying) text file.
> 
> This is aimed at replacing safe_asterisk with a more reliable main loop. It almost does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop command does not get the exist status of the stopped command.
> 
> 
> Diffs
> -----
> 
>   /trunk/contrib/asterisk.service PRE-CREATION 
>   /trunk/Makefile 404563 
> 
> Diff: https://reviewboard.asterisk.org/r/3062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140101/1873b06b/attachment-0001.html>