[asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

[Jonathan Rose]

> On Dec. 6, 2013, 9:02 p.m., Jonathan Rose wrote:
> > Ok, this time it's just reviewboard being stupid.  They are showing up in the diff file.

D       configs
D       configs/ast1
D       configs/ast1/extensions.conf
D       configs/ast1/amd.conf
D       configs/ast1/iax.conf
A       page_predial
A       page_predial/test-config.yaml
A       page_predial/configs
A       page_predial/configs/ast1
A       page_predial/configs/ast1/extensions.conf
A       page_baseline
A  +    page_baseline/test-config.yaml
A  +    page_baseline/configs
A  +    page_baseline/run-test
D       run-test
D       test-config.yaml
A       tests.yaml


I had previously left out the new tests.yaml. Here is the output of svn state from the tests/apps/page directory though.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3053/#review10323
-----------------------------------------------------------


On Dec. 6, 2013, 9:01 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3053/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 9:01 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, opticron, and rmudgett.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Pretty straightforward. Tests that predial handlers are applied on the appropriate channels when app_page uses the predial options. See the test yaml for a slightly more in depth description.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/tests.yaml 4407 
>   /asterisk/trunk/tests/apps/page/test-config.yaml 4397 
>   /asterisk/trunk/tests/apps/page/run-test 4397 
>   /asterisk/trunk/tests/apps/page/page_predial/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/page/page_predial/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/page/configs/ast1/iax.conf 4397 
>   /asterisk/trunk/tests/apps/page/configs/ast1/extensions.conf 4397 
>   /asterisk/trunk/tests/apps/page/configs/ast1/amd.conf 4397 
> 
> Diff: https://reviewboard.asterisk.org/r/3053/diff/
> 
> 
> Testing
> -------
> 
> It runs and it doesn't fail with the patch applied.  It does without the patch applied.  I checked through logs to make sure channels hit everything in the PBX as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131206/fd5faa1f/attachment-0001.html>