<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3053/">https://reviewboard.asterisk.org/r/3053/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 6th, 2013, 9:02 p.m. UTC, <b>Jonathan Rose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, this time it's just reviewboard being stupid. They are showing up in the diff file.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">D configs
D configs/ast1
D configs/ast1/extensions.conf
D configs/ast1/amd.conf
D configs/ast1/iax.conf
A page_predial
A page_predial/test-config.yaml
A page_predial/configs
A page_predial/configs/ast1
A page_predial/configs/ast1/extensions.conf
A page_baseline
A + page_baseline/test-config.yaml
A + page_baseline/configs
A + page_baseline/run-test
D run-test
D test-config.yaml
A tests.yaml
I had previously left out the new tests.yaml. Here is the output of svn state from the tests/apps/page directory though.</pre>
<br />
<p>- Jonathan</p>
<br />
<p>On December 6th, 2013, 9:01 p.m. UTC, Jonathan Rose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson, opticron, and rmudgett.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2013, 9:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pretty straightforward. Tests that predial handlers are applied on the appropriate channels when app_page uses the predial options. See the test yaml for a slightly more in depth description.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It runs and it doesn't fail with the patch applied. It does without the patch applied. I checked through logs to make sure channels hit everything in the PBX as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/apps/tests.yaml <span style="color: grey">(4407)</span></li>
<li>/asterisk/trunk/tests/apps/page/test-config.yaml <span style="color: grey">(4397)</span></li>
<li>/asterisk/trunk/tests/apps/page/run-test <span style="color: grey">(4397)</span></li>
<li>/asterisk/trunk/tests/apps/page/page_predial/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/page/page_predial/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/page/configs/ast1/iax.conf <span style="color: grey">(4397)</span></li>
<li>/asterisk/trunk/tests/apps/page/configs/ast1/extensions.conf <span style="color: grey">(4397)</span></li>
<li>/asterisk/trunk/tests/apps/page/configs/ast1/amd.conf <span style="color: grey">(4397)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3053/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>