[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[Mark Michelson]

> On April 25, 2013, 3:22 p.m., opticron wrote:
> > team/group/pimp_my_sip/res/res_sip.c, lines 101-103
> > <https://reviewboard.asterisk.org/r/2471/diff/1/?file=36406#file36406line101>
> >
> >     This isn't a valid configuration option for the endpoint config option.

It appears all of the items that you've said this about are actually valid options for other types of configurable items. This, for instance is a configuration option for aors.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8351
-----------------------------------------------------------


On April 25, 2013, 2:07 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 2:07 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/res/res_sip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_acl.c 386331 
>   team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_outbound_registration.c 386331 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/28f6b96f/attachment-0001.htm>