[asterisk-dev] [Code Review] 2438: Add Stasis capability and AMI events around bridges

opticron reviewboard at asterisk.org
Thu Apr 11 09:17:26 CDT 2013



> On April 11, 2013, 12:33 a.m., David Lee wrote:
> > team/group/bridge_construction/main/stasis_bridging.c, line 81
> > <https://reviewboard.asterisk.org/r/2438/diff/2/?file=35731#file35731line81>
> >
> >     An ao2_strdup would be useful.

Created ast_str_container_add helper function.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2438/#review8226
-----------------------------------------------------------


On April 10, 2013, 2:15 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2438/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 2:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21057
>     https://issues.asterisk.org/jira/browse/ASTERISK-21057
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds the base of Stasis messages, topics, message types, caches, and snapshot generation points within the bridging code to facilitate access to bridge information without accessing bridges directly and also adds AMI events for bridge changes built on top of that Stasis layer.
> 
> The new function in strings.h (ast_str_container_alloc) allocates a new AO2 container for bare strings since this functionality seems to be required quite a bit more often lately.
> 
> 
> Diffs
> -----
> 
>   team/group/bridge_construction/include/asterisk/manager.h 385233 
>   team/group/bridge_construction/include/asterisk/stasis_bridging.h PRE-CREATION 
>   team/group/bridge_construction/include/asterisk/strings.h 385233 
>   team/group/bridge_construction/main/asterisk.c 385233 
>   team/group/bridge_construction/main/bridging.c 385233 
>   team/group/bridge_construction/main/manager.c 385233 
>   team/group/bridge_construction/main/manager_bridging.c PRE-CREATION 
>   team/group/bridge_construction/main/manager_channels.c 385233 
>   team/group/bridge_construction/main/stasis_bridging.c PRE-CREATION 
>   team/group/bridge_construction/main/strings.c 385233 
> 
> Diff: https://reviewboard.asterisk.org/r/2438/diff/
> 
> 
> Testing
> -------
> 
> Tested with Confbridge and BridgeWait to verify correct events are generated when calls enter and leave bridges.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/07e2f839/attachment.htm>


More information about the asterisk-dev mailing list