[asterisk-dev] [Code Review] 2438: Add Stasis capability and AMI events around bridges

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2438/#review8226
-----------------------------------------------------------


Handful of minor issues. No big objections.


team/group/bridge_construction/include/asterisk/manager.h
<https://reviewboard.asterisk.org/r/2438/#comment15867>

    Now that this has been extracted to manager.h, the name make less sense out of context.



team/group/bridge_construction/include/asterisk/manager.h
<https://reviewboard.asterisk.org/r/2438/#comment15873>

    Now that this is a public function, this is worth a comment that this should be a string literal. Either that, or make the implementation strdup() the string.



team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15868>

    I'd be fine if it's not opaque, so long as there's some convenience functions for accessing the contents of the ao2_container.



team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15869>

    s/chan/bridge/



team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15870>

    s/ast_free/ao2_cleanup/



team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15871>

    s/Topic/Cached topic/



team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15865>

    type s/merger/merge/



team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15872>

    You should stick with the from/to terminology.



team/group/bridge_construction/main/manager_bridging.c
<https://reviewboard.asterisk.org/r/2438/#comment15875>

    Respond with error.



team/group/bridge_construction/main/stasis_bridging.c
<https://reviewboard.asterisk.org/r/2438/#comment15877>

    An ao2_strdup would be useful.



team/group/bridge_construction/main/stasis_bridging.c
<https://reviewboard.asterisk.org/r/2438/#comment15878>

    Stick to to/from instead of bridge1/bridge2.



team/group/bridge_construction/main/stasis_bridging.c
<https://reviewboard.asterisk.org/r/2438/#comment15879>

    ditto


- David Lee


On April 10, 2013, 2:15 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2438/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 2:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21057
>     https://issues.asterisk.org/jira/browse/ASTERISK-21057
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds the base of Stasis messages, topics, message types, caches, and snapshot generation points within the bridging code to facilitate access to bridge information without accessing bridges directly and also adds AMI events for bridge changes built on top of that Stasis layer.
> 
> The new function in strings.h (ast_str_container_alloc) allocates a new AO2 container for bare strings since this functionality seems to be required quite a bit more often lately.
> 
> 
> Diffs
> -----
> 
>   team/group/bridge_construction/include/asterisk/manager.h 385233 
>   team/group/bridge_construction/include/asterisk/stasis_bridging.h PRE-CREATION 
>   team/group/bridge_construction/include/asterisk/strings.h 385233 
>   team/group/bridge_construction/main/asterisk.c 385233 
>   team/group/bridge_construction/main/bridging.c 385233 
>   team/group/bridge_construction/main/manager.c 385233 
>   team/group/bridge_construction/main/manager_bridging.c PRE-CREATION 
>   team/group/bridge_construction/main/manager_channels.c 385233 
>   team/group/bridge_construction/main/stasis_bridging.c PRE-CREATION 
>   team/group/bridge_construction/main/strings.c 385233 
> 
> Diff: https://reviewboard.asterisk.org/r/2438/diff/
> 
> 
> Testing
> -------
> 
> Tested with Confbridge and BridgeWait to verify correct events are generated when calls enter and leave bridges.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/cb12481b/attachment-0001.htm>