[asterisk-dev] [Code Review] 2415: Add inheritance support to FEATURE()/FEATUREMAP().

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2415/#review8208
-----------------------------------------------------------

Ship it!


Looks good.

I do think we're moving away from this being the preferred mechanism to set properties on child channels, but as you noted on the issue, Queue doesn't (yet) support Pre-Dial. I expect that won't be the case by the time 12 comes out, but this feature is still a nice convenience mechanism to have.

- Matt Jordan


On April 8, 2013, 4:59 p.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2415/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 4:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21306
>     https://issues.asterisk.org/jira/browse/ASTERISK-21306
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
>     The settings saved on the channel for FEATURE()/FEATUREMAP() were only
>     for that channel.  This patch adds the ability to have these settings
>     inherited to child channels if you set FEATURE(inherit)=yes.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features.c 384971 
>   /trunk/CHANGES 384971 
> 
> Diff: https://reviewboard.asterisk.org/r/2415/diff/
> 
> 
> Testing
> -------
> 
> Tested using the following dialplan by calling 104.
> 
> 
> exten =>      foo2,1,Answer()
> same =>      n,Verbose(0,blindxfer should be 77: ${FEATUREMAP(blindxfer)})
> same =>      n,Verbose(0,parkingtime should be 5: ${FEATURE(parkingtime)})
> 
> ; Test FEATURE(inherit). Set the parkingtime and a feature mapping
> ; on the original channel, and then verify that it's inherited to
> ; the called channel.
> exten =>      104,1,Answer()
> same =>      n,Verbose(0,Test feature inheritance.)
> same =>      n,Set(FEATURE(parkingtime)=5)
> same =>      n,Set(FEATUREMAP(blindxfer)=77)
> same =>      n,Set(FEATURE(inherit)=yes)
> same =>      n,Dial(Local/foo2 at featuretest,,tT)
> 
> 
> Thanks,
> 
> Russell Bryant
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130408/d51527f4/attachment-0001.htm>