<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2415/">https://reviewboard.asterisk.org/r/2415/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good.
I do think we're moving away from this being the preferred mechanism to set properties on child channels, but as you noted on the issue, Queue doesn't (yet) support Pre-Dial. I expect that won't be the case by the time 12 comes out, but this feature is still a nice convenience mechanism to have.</pre>
<br />
<p>- Matt</p>
<br />
<p>On April 8th, 2013, 4:59 p.m. UTC, Russell Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Russell Bryant.</div>
<p style="color: grey;"><i>Updated April 8, 2013, 4:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21306">ASTERISK-21306</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> The settings saved on the channel for FEATURE()/FEATUREMAP() were only
for that channel. This patch adds the ability to have these settings
inherited to child channels if you set FEATURE(inherit)=yes.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using the following dialplan by calling 104.
exten => foo2,1,Answer()
same => n,Verbose(0,blindxfer should be 77: ${FEATUREMAP(blindxfer)})
same => n,Verbose(0,parkingtime should be 5: ${FEATURE(parkingtime)})
; Test FEATURE(inherit). Set the parkingtime and a feature mapping
; on the original channel, and then verify that it's inherited to
; the called channel.
exten => 104,1,Answer()
same => n,Verbose(0,Test feature inheritance.)
same => n,Set(FEATURE(parkingtime)=5)
same => n,Set(FEATUREMAP(blindxfer)=77)
same => n,Set(FEATURE(inherit)=yes)
same => n,Dial(Local/foo2@featuretest,,tT)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/features.c <span style="color: grey">(384971)</span></li>
<li>/trunk/CHANGES <span style="color: grey">(384971)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2415/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>